User Tools

Site Tools


playground:repository_guidelines

Differences

This shows you the differences between two versions of the page.

Link to this comparison view

playground:repository_guidelines [2014/03/04 20:45]
rsjtdrjgfuzkfg initial draft
playground:repository_guidelines [2014/03/06 05:48] (current)
freaktechnik [Pull Requests] We should always have at least two eyes looking over the code
Line 40: Line 40:
   * He/She tested the pull request actually works as advertised, and/or other trusted community members agreed on merging it in without testing   * He/She tested the pull request actually works as advertised, and/or other trusted community members agreed on merging it in without testing
   * He/She tested the pull request does not break building or basic features (a short test is sufficient)   * He/She tested the pull request does not break building or basic features (a short test is sufficient)
 +  * At least one other trusted community member reviewed the changes and gave an OK to merge (can be via IRC or as a comment)
  
 Trusted community members **must not merge if the above conditions are not met**. They are encouraged //not// to merge pull requests if they are unsure, even if they have push privileges. Merging without another community member commenting positively should get avoided in all non-trivial cases. Trusted community members **must not merge if the above conditions are not met**. They are encouraged //not// to merge pull requests if they are unsure, even if they have push privileges. Merging without another community member commenting positively should get avoided in all non-trivial cases.
playground/repository_guidelines.txt ยท Last modified: 2014/03/06 05:48 by freaktechnik